Implement 2FA for Umbrel-Manager #111
Conversation
| // update system password | ||
| await setSystemPassword(newPassword); |
There was a problem hiding this comment.
Maybe reverting these changes would help getting this merged. I recommend to not lint any of your PRs, Umbrel hasn't used a configured linter in any project for over a year now, even though that could've prevented some bugs.
|
|
||
| req.logIn(user, function (err) { | ||
|
|
||
|
|
There was a problem hiding this comment.
Please revert this too to keep changes minimal.
Co-authored-by: Aaron Dewes <aaron.dewes@protonmail.com>
|
Hey thanks for working on this @dsbaars! We decided to go for a slightly different approach: The passport-totp module doesn't really fit well with our existing codebase since we don't use sessions for authentication. Also we wanted to build 2FA into the existing authentication endpoints as opposed to adding new ones, along with doing a custom UI for it. Really appreciate you taking the time to put this together though! |
Implementing 2FA using TOTP as requested in getumbrel/umbrel#985 and getumbrel/umbrel#1078.
Also needs modified version of umbrel-dashboard, related pull request getumbrel/umbrel-dashboard#395