Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Helipad app to v0.1.9 #1278

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Update Helipad app to v0.1.9 #1278

merged 1 commit into from
Feb 28, 2022

Conversation

daveajones
Copy link
Contributor

No description provided.

@lukechilds
Copy link
Member

lukechilds commented Feb 28, 2022 •
edited
Loading

Thanks @daveajones!

@lukechilds lukechilds merged commit 447aa8d into getumbrel:master Feb 28, 2022
@nevets963
Copy link
Contributor

Hey @daveajones I just tested Helipad on my Umbrel node using regtest network. But it fails to start complaining it can't find the mainnet admin macaroon.

Could you enhance Helipad a little to accept an environment variable that uses $BITCOIN_NETWORK (defined by Umbrel) to know which network is active and then to read the correct macaroon. I guess you have mainnet hardcoded at the moment.

Thanks!

@daveajones daveajones mentioned this pull request Feb 28, 2022
Open
@daveajones
Copy link
Contributor Author

Hey @daveajones I just tested Helipad on my Umbrel node using regtest network. But it fails to start complaining it can't find the mainnet admin macaroon.

Could you enhance Helipad a little to accept an environment variable that uses $BITCOIN_NETWORK (defined by Umbrel) to know which network is active and then to read the correct macaroon. I guess you have mainnet hardcoded at the moment.

Thanks!

Sure, I'll gladly do that. Yes, it's hard-coded currently.

Issue here: #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daveajones @lukechilds @nevets963