Add lnbits app #372

louneskmt · 2020-12-29T19:50:58Z

App Submission

App name

LNbits

Version

v0.2.0

One line description of the app

(max 50 characters)

Multi-user wallet management system

Summary of the app

(50 to 200 words)

LNbits is a simple multi-user and account system for Lightning Network that can be used for creating separate Lightning wallets for friends and family members. You can also create multiple accounts for yourself to mitigate the risk of exposing applications to your full balance via unique API keys for each wallet.

LNbits is packaged with tools to help manage funds, such as a table of transactions, line chart of spending, export to CSV, and more to come. It provides an extendable platform for expanding Lightning Network functionality via LNbits extension framework, and can also be used as a fallback wallet for the LNURL scheme.

Developed by

LNbits

Developer website

https://github.com/lnbits/lnbits

Source code repository

https://github.com/lnbits/lnbits

Support link

(Link to your Telegram support channel, GitHub issues/discussions, support portal, or any other place where users could contact you for support.)

https://t.me/lnbits

Uses

Bitcoin Core
Electrum server
LND

256x256 SVG icon

(GitHub doesn't allow uploadig SVGs directly. Upload your file to an alternate service, like https://svgur.com, and paste the link below.)

App screenshots

(Upload 3 to 5 high-quality screenshots (at least 1280x800px) of your app in PNG format.)

I have tested my app on:

mayankchhabra

Really nice job on packaging LNbits, @louneskmt! Works flawlessly.

louneskmt · 2021-02-13T08:00:57Z

Source: https://github.com/louneskmt/docker-lnbits

mayankchhabra · 2021-02-13T09:32:46Z

cc @arcbtc: LNbits looks ready to be shipped in the next Umbrel release! Can you please quickly eyeball this once?

Also, everything in the PR description above is what the user will see in the LNbits app description on the Umbrel App Store, along with the app icon and gallery images here (getumbrel/umbrel-apps-gallery#4). So feel free to suggest any edits if you'd like.

lukechilds · 2021-02-13T18:48:47Z

apps/lnbits/docker-compose.yml

+      # App
+      LNBITS_SITE_TITLE: "LNbits - Umbrel"
+      LNBITS_DEFAULT_WALLET_NAME: "LNbits wallet"
+      LNBITS_DISABLED_EXTENSIONS: "amilk"


Why is this extension disabled?

It allows an user to automatically claim sats from an LNURLw. For example, a LNURL to claim 1000 sats every minute. I found this pretty unfair as the delay is here to allow more people to claim sats (e.g. a test LNURL in a Bitcoin bar, for newbies to discover Lightning) and not just have a single person claiming the whole balance.

If necessary I can enable it.

Hmmn, I agree that doesn't sound like very nice behaviour but I'm not sure it should be our decision to blacklist it.

It's not doing anything bad by default, right? A user would have to manually enable it?

A user would have to manually enable it?

Each extension has to be activated from the extensions page.

But of the extension is disabled in this env var, it cannot be installed from the web page. So yeah, if it shouldn't be our decision to blacklist it, we should remove this line.

Keep it disabled until we manage to improve it for future LNbits release

lukechilds · 2021-02-13T19:35:20Z

apps/lnbits/docker-compose.yml

+      LNBITS_SITE_TITLE: "LNbits - Umbrel"
+      LNBITS_DEFAULT_WALLET_NAME: "LNbits wallet"
+      LNBITS_DISABLED_EXTENSIONS: "amilk"
+      LNBITS_ALLOWED_USERS: ""


Why is this empty?

Are there any docs for these settings? I had a quick look at the LNbits repo but didn't find any.

I used the default values here: https://github.com/lnbits/lnbits/blob/master/.env.example

lukechilds · 2021-02-13T20:07:32Z

Is the app being built in development mode?

https://github.com/louneskmt/docker-lnbits/blob/4767453412e8c70249940586fe5cddc0f0fbb396/Dockerfile#L10

louneskmt · 2021-02-13T20:40:03Z

Is the app being built in development mode?

https://github.com/louneskmt/docker-lnbits/blob/4767453412e8c70249940586fe5cddc0f0fbb396/Dockerfile#L10

I don't think so, this is the default value. Maybe LNbits needs Quark in dev mode, idk.

https://lnbits.org/guide/installation.html

apps/lnbits/docker-compose.yml

lukechilds · 2021-02-14T09:42:16Z

apps/lnbits/docker-compose.yml

+      LNBITS_DEFAULT_WALLET_NAME: "LNbits wallet"
+      LNBITS_DISABLED_EXTENSIONS: "amilk"
+      LNBITS_ALLOWED_USERS: ""
+      LNBITS_FORCE_HTTPS: "true"


Do you know what this option does?

It doesn't appear to be using HTTPS at all for me.

Not really. I think we can get ride of these 3 lines (disabled extensions, force http and allowed users).

lukechilds

Looking good, nice job!

lukechilds · 2021-02-14T09:59:09Z

No point blocking the merge for this but the Docker image is very large:

$ docker images louneskmt/lnbits:v0.2.0
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
louneskmt/lnbits    v0.2.0              27290287067a        6 weeks ago         412MB

The final image is including all of the build dependencies. It could probably be reduced in size significantly by using multistage builds and only including runtime deps in the resulting image.

It also isn't checksumming any external files it pulls in, which can make the images non-deterministic and hard to verify.

See https://github.com/getumbrel/umbrel/tree/master/apps#a-good-dockerfile for how to resolve this.

louneskmt · 2021-02-14T10:21:45Z

Thanks, will try to improve this for the next version.

The dojo-whirlpool image is also 600 MB, but I used their Dockerfile. Maybe I will modify it to make a smaller final image.

arcbtc · 2021-02-14T11:02:41Z

Wow, ace work:

Ditch "Developer website" as we are not really maintaining .org, directing folks to github repo is best
Add https://t.me/lnbits to support links
Keep amilk disabled, its too buggy/resource intensive to have easy access to
For one line description, it would be nice to get the extensions in there "Multi-user and wallet system for Lightning Network, with extension system for adding additional functionality such as LNURL"

arcbtc · 2021-02-14T11:03:38Z

Only if I am not too late that is!

mayankchhabra · 2021-02-14T11:26:08Z

Only if I am not too late that is!

You're in luck, we just realized that it's Valentines so we're delaying the release by a day lol.

The changes sound good. Regarding the one-line description, there's a 50 character limit on it. I know you can't really fit in the the entire description in 50 characters, but think of it more like a tagline for LNbits, rather than a description. Here's where it shows up in the app store:

Currently it's set to "Multi-user wallet management system", but let us know if you'd like to change it to something else.

arcbtc · 2021-02-14T11:31:28Z

Oh yeah, that's nice 👍, leave it like that

louneskmt added 7 commits December 29, 2020 23:44

Add lnbits app

9f57d73

Merge 'master'

1f90db7

Change image tag + port and move config to compose file

2a0f468

Fix errors from previous commit (incorrect port + env file import)

d20bae0

Update config

211cfaf

Add app IP and Tor hidden service

16c4703

Reduce stop grace period

ad68119

louneskmt marked this pull request as ready for review February 4, 2021 21:34

mayankchhabra added 9 commits February 12, 2021 17:21

Add mempool to registry

6601e48

remove conflicts

de93690

Merge remote-tracking branch 'upstream/master'

d56937c

Merge remote-tracking branch 'upstream/master'

88eabb4

Merge remote-tracking branch 'upstream/master'

b0cdeb7

Merge remote-tracking branch 'upstream/master'

f62b2d5

Resolve conflicts

34b026a

Remove conflicts

df2116d

Add init

6702ba0

mayankchhabra previously approved these changes Feb 13, 2021

View reviewed changes

lukechilds reviewed Feb 13, 2021

View reviewed changes

lukechilds reviewed Feb 14, 2021

View reviewed changes

apps/lnbits/docker-compose.yml Outdated Show resolved Hide resolved

lukechilds dismissed mayankchhabra’s stale review via 1a89be4 February 14, 2021 09:40

Pin Docker image

1a89be4

lukechilds reviewed Feb 14, 2021

View reviewed changes

lukechilds added 2 commits February 14, 2021 16:47

Don't disable AMilk extension

a5455eb

Remove redundant environment variables

b7985d3

lukechilds approved these changes Feb 14, 2021

View reviewed changes

lukechilds closed this Feb 14, 2021

lukechilds reopened this Feb 14, 2021

lukechilds merged commit 09bfeef into getumbrel:master Feb 14, 2021

louneskmt deleted the lnbits branch February 14, 2021 10:21

mayankchhabra mentioned this pull request Feb 14, 2021

Add lnbits app to registry #528

Merged

mayankchhabra mentioned this pull request Feb 14, 2021

Update lnbits app in registry #530

Merged

lukechilds mentioned this pull request Feb 19, 2021

Disable AMilk extension in lnbits app #552

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lnbits app #372

Add lnbits app #372

louneskmt commented Dec 29, 2020 •

edited by mayankchhabra

mayankchhabra left a comment

louneskmt commented Feb 13, 2021

mayankchhabra commented Feb 13, 2021 •

edited

lukechilds Feb 13, 2021

louneskmt Feb 13, 2021

lukechilds Feb 13, 2021 •

edited

louneskmt Feb 13, 2021

louneskmt Feb 14, 2021

arcbtc Feb 14, 2021

lukechilds Feb 13, 2021

louneskmt Feb 13, 2021

lukechilds commented Feb 13, 2021 •

edited

louneskmt commented Feb 13, 2021

lukechilds Feb 14, 2021

louneskmt Feb 14, 2021 •

edited

lukechilds left a comment

lukechilds commented Feb 14, 2021

louneskmt commented Feb 14, 2021

arcbtc commented Feb 14, 2021 •

edited

arcbtc commented Feb 14, 2021

mayankchhabra commented Feb 14, 2021

arcbtc commented Feb 14, 2021

Add lnbits app #372

Add lnbits app #372

Conversation

louneskmt commented Dec 29, 2020 • edited by mayankchhabra

App Submission

App name

Version

One line description of the app

Summary of the app

Developed by

Developer website

Source code repository

Support link

Uses

256x256 SVG icon

App screenshots

I have tested my app on:

mayankchhabra left a comment

Choose a reason for hiding this comment

louneskmt commented Feb 13, 2021

mayankchhabra commented Feb 13, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukechilds Feb 13, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukechilds commented Feb 13, 2021 • edited

louneskmt commented Feb 13, 2021

Choose a reason for hiding this comment

louneskmt Feb 14, 2021 • edited

Choose a reason for hiding this comment

lukechilds left a comment

Choose a reason for hiding this comment

lukechilds commented Feb 14, 2021

louneskmt commented Feb 14, 2021

arcbtc commented Feb 14, 2021 • edited

arcbtc commented Feb 14, 2021

mayankchhabra commented Feb 14, 2021

arcbtc commented Feb 14, 2021

louneskmt commented Dec 29, 2020 •

edited by mayankchhabra

mayankchhabra commented Feb 13, 2021 •

edited

lukechilds Feb 13, 2021 •

edited

lukechilds commented Feb 13, 2021 •

edited

louneskmt Feb 14, 2021 •

edited

arcbtc commented Feb 14, 2021 •

edited