DBs fxns #17
Merged
DBs fxns #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stop within rds con fxn as not ready yet - redshift con fxn changes: user/pwd required and no default, get other params from cluster id - redshift create fxn: add security group, wait until available - many helper fxns - improved docs
|
So cool, cannot wait to get this into people's hands. |
|
Thanks @seankross - I'll work on the RDS function(s) and hopefully have it ready to review with the Redshift one when you get back |
- new files for db stuff, separate files for redshift, rds and wait fxns - add rds functions - modify wait functions to use common plumbing with generator for each of redshift, rds - now importing RMariaDB
- add misc file for database helpers - add info() fxn to give back info on the newly created rds or redshift instance - add tests for some of the db fxns - rds: toggle which DBI driver loaded; and only check for the single DB driver pkg for the engine - redshift: add info() usage in create fxn, and verbose param - wait_until - add info about waiting on instance
|
Okay @seankross You can now try spinning up RDS and Redshift instance, and connecting to them. See Notion private docs for notes. |
seankross
reviewed
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seankross take a look please.
note: instructions/examples with secrets in notion, see slack dm
This PR adds fxns for dealing with Redshift. There is a fxn for RDS, but it's not working yet so ignore that.
What do you not like about any of this? Any possible improvements?
#8