More magical fxns #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AttachedUserPolicies, iam:ListGroupsForUser to six_user_create;
…record test fixtures test fixes add namespace changes to last commit
… too; associated fixes to other policy fxns that use as_policy_arn
….. to paginator fxn
… reproducible; export random string helper to use in egs
…fxns back as not exported
|
@seankross removed the simulate user code - I put the code for it in another issue #57 |
Open
|
Hey @sckott of course in the testing of this new functionality I've been deleting and creating all kinds of things on our AWS account. Is there anything in particular that should or should not exist before I test |
|
Nah . In the test account go for deleting anything |
|
And you can pass any string to admin or users to not overwrite the existing ones |
- as part of addressing six_file_upload, reworked s3 connection acquisition for paws and s3fs - rework tests to work with new s3 connection - rename random_str to random_db_id_str
… r6 file system class in s3fs directly
…anager connection situation
…ng objects and the bucket; test data version 2
…bucket and all objects in bucket
- fix whats magical - fix checks at the top of the fxn to make it work for path length > 1 - improve error messages for those checks - clarify that the fxn doesnt accept directories
…oad; remove s3fs fxn imports that are not used
…race and cli messages
- remove a few files in R/ with client objects for infidivual aws services - new file constants.R for constants in setting up clients - new file clients.R with factory to generate clients for paws, and redefine s3fs client - new print s3 method for client objects instead of showing a massively long list
|
🚀 Deployed on https://deploy-preview-55--teal-chaja-b4836e.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53
Some notes:
six_admin_setup
It does 2 things right now:
I tried to make it do a 3rd thing: Simulate a user and make sure that user can access all the resources that are given by the policies attached to the user group. I went through a few iterations of this but haven't sorted it out yet. Do you think this is important? If not, we can maybe come back to it later.
Other magical fxns
Any others we should add?