-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Queuing; Refactor Extractors to Tasks; refactor MemoryStore interface #246
Conversation
danielchalef
commented
Oct 28, 2023
•
edited
Loading
edited
- Add SQL TaskQueue using Watermill
- Refactor Extractors to new Task queue model
- Refactor MemoryStore Interfaces as precursor to refactoring MemoryStore
- Code cleanup
@danielchalef wow, looks like a ton of work went into this one. I am not familiar with Go yet to grok all the changes. But does this require any migrations? Or does Go code migrate implicitly when you start the service? Are there any docs for this change? Thanks!! |
@moltar No migrations were necessary. The functional router "Task" schemas remained the same as the prior "Extractor" tasks. The message queue framework I used automatically generates schemas for each handler. Since this change was an internal shift from an observer model using Go channels as queues, to a SQL-based message queue architecture, I've not prioritized documenting it! I will get around to doing so sometime soon! |
Alright thank you for explaining. I was only looking for any end user docs, but sounds like none needed. I was thinking in the context of applying database migrations manually for this change. But given that it's under the hood implementation detail then is all good. |