Improve multi-language support #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxter184
commented
Jul 3, 2022
templates/tags/list.html
Outdated
| @@ -5,7 +5,7 @@ | |||
| {{ super() }} | |||
| {% endblock header %} | |||
|
|
|||
| <h1>Tags</h1> | |||
| <h1>{% if config.extra.after_dark_multilingual %}{{ trans(key="tags", lang=lang) }}{% else %}Tags{% endif %}</h1> | |||
There was a problem hiding this comment.
The config.extra.after_dark_multilingual flag is only here for backwards compatibility. If breaking existing configurations is OK, or if there is a way to check if a translation key exists, the flag can be removed.
There was a problem hiding this comment.
I believe you can just check config.language | length, if it's more than 1 then it's a multi-language site?
|
Hmm, I thought it was backwards compatible, but it looks like its not, maybe because the current config has no |
|
Configs should always have a |
|
Not sure what I did to close the fork 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a language menu and fixes #18 (menu item behavior for non-default languages). Functionality and implementation roughly based on Papaya.
Fully backwards compatible. To fix #18, add
trans_key = "abc"to theextra.after_dark_menulist andabc = "xxx"to each language'stranslationslist.