Default RSS template generates invalid feeds

[kanru]

Bug Report

Environment

Zola version: 0.8.0

Expected Behavior

RSS feed is validated by https://validator.w3.org/feed/ and RSS readers

Current Behavior

Generated RSS feed urlencodes the whole URL, which has some undesirable effects:

1. Not considered valid by W3C feed validator.
2. RSS readers like Feedly and Inoreader both thought the URL is a relative link so concatenate the channel link and the item link which generates a complete wrong link to the article.

Step to reproduce

1. zola init test
2. Add an article with date
3. zola build

Paste the generated public/rss.xml to https://validator.w3.org/feed/check.cgi

For example

https://gist.github.com/kanru/3926d9ad1a8b6ce5586fe7bad301dbfb

has following errors

1. line 5, column 35: link must be a full and valid URL: https%3A//example.com
2. line 15, column 56: link must be a full and valid URL: https%3A//example.com/hello-world/
3. line 16, column 56: guid must be a full URL, unless isPermaLink attribute is false: https%3A//example.com/hello-world/
4. line 9, column 95: Relative href value on self link: https%3A//example.com/rss.xml

RSS reader would generate something like: https://example.com/https%3A//example.com/https%3A//example.com/hello-world/

[Keats]

A bug in the RSS namespace already be fixed in the next branch if you want to give it a try (reported in #722)

The reason it is encoding everything was to fix #705 and that I thought tools would just understand encoded URLs :(.

[kanru]

Cool, I'll give the next branch a try!

[Keats]

It's not fixing the urlencoding yet though! Only the namespace that was invalid

[kanru]

Gotcha. I guess we need a url_safe filter or wrap the content in <![CDATA[ ]]> everywhere.

[Keats]

Yeah, I'm not sure what's the best solution. I think not allowing & and other special characters in the slugs is the simplest fix

[jlricon]

As next is failing to build, if anyone stumbles on this thread, the quickest fix is just to add a

sed -i 's/%3A/:/g' public/sitemap.xml
sed -i 's/%3A/:/g' public/rss.xml

to the build script, until the issue gets resolved.

[Keats]

What error do you get with next? It should build correctly, unless you talk about the RSS templates themselves?

[jlricon]

Here it is: https://paste.ubuntu.com/p/xGN72JDdVZ/
cargo build --release works fine for master on my laptop (Ubuntu 19.04).

[Keats]

Really weird, I don't get that error and all CI pass for next 😕

[jlricon]

Hm, I'll look later if there's anything wrong with my setup. I even did a cargo clean in-between, and I don't have any odd custom versions of build-utils

[Keats]

Do you maybe have a global installation of libsass somehow?

[jlricon]

I realised I wasn't running it inside nix-shell; doing it fixed the build!

[Keats]

The next branch should be working fine again.