Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bibtex support to load_data() #1190

Merged
merged 4 commits into from
Nov 21, 2020
Merged

Add bibtex support to load_data() #1190

merged 4 commits into from
Nov 21, 2020

Conversation

rmsc
Copy link
Contributor

@rmsc rmsc commented Sep 30, 2020

Discourse thread open here.

The changes are fairly small and innocuous, but for people working in academia it's a pretty big deal.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

@rmsc rmsc changed the title Next Add bibtex support to load_data() Sep 30, 2020
Copy link
Collaborator

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok, I just want a bit more documentation - sorry for not replying on the forum.

I have never heard of bibtex, is it something commonly used?

Cargo.lock Show resolved Hide resolved
docs/content/documentation/templates/overview.md Outdated Show resolved Hide resolved
@rmsc
Copy link
Contributor Author

rmsc commented Oct 5, 2020

The code looks ok, I just want a bit more documentation - sorry for not replying on the forum.

Sure, no problem.

I have never heard of bibtex, is it something commonly used?

Yes, it's widely used in academia as a way to store bibliography entries. Some people keep files with hundreds of entries. For people wanting to showcase their publications on their site it's a lot easier to automatically convert them to site content.

One possible alternative to this patch is to use some script to convert from bibtex to json or md, but that complicates the flow somewhat.

@savente93
Copy link
Contributor

I would actually love this feature. Right now I have a hacky work around for my own website. Is this gonna get merged anytime soon?

@Keats
Copy link
Collaborator

Keats commented Oct 30, 2020

It's just missing the updated documentation

@rmsc
Copy link
Contributor Author

rmsc commented Oct 30, 2020

Sorry, my bad, still wasn't able to get this done..

@rmsc
Copy link
Contributor Author

rmsc commented Nov 16, 2020

I've updated the documentation, sorry for how long that took..

The whole documentation for 'load_data' did get a bit long. Do you think it's still manageable, or should 'overview.md' be split somehow? I'll have some time in the following days to work on that if you think it's worth it.

@Keats
Copy link
Collaborator

Keats commented Nov 21, 2020

Yeah this page will need to be split at some point... thanks!

@Keats Keats merged commit 55fd96a into getzola:next Nov 21, 2020
Keats pushed a commit that referenced this pull request Dec 14, 2020
* Add support for loading Bibtex data.

* Add load_data() documentation for the bibtex format

* Force bibtex tags to be lower case.

Bibtex tags are case-insensitive, and this works around tera's case-sensitiveness.

* Improve the load_data() documentation for the bibtex format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants