move translation population and path collision checking to insert stage #1272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR in response to #1112.
next
branch?Code changes
I moved the path collision checking and the translation population to the insertion into the library stage. This is to save a few iterations across pages and sections. It did necessitate extra indices for the library, but for aliases and translations, I think that is acceptable since it should be relatively slim in most cases. I have some comments about other possible improvements but I'll add those to the issue discussion itself