Add slugify.paths_keep_dates option. Update docs. #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase the PR? |
|
(oops, deleted the next branch in my fork when I synced it) Rebased. |
Keats
reviewed
Aug 16, 2022
| # Whether to remove date prefixes for page path slugs. | ||
| # For example, content/posts/2016-10-08_a-post-with-dates.md => posts/a-post-with-dates | ||
| # When true, content/posts/2016-10-08_a-post-with-dates.md => posts/2016-10-08-a-post-with-dates | ||
| paths_keep_dates = false |
There was a problem hiding this comment.
Just bike shedding on the name: anyone has a better name? I'm not too sold on this one
Manual testing: Existing test_site/config.toml http://127.0.0.1:1111/posts/a-post-with-dates ==== --- a/test_site/config.toml +++ b/test_site/config.toml @@ -18,6 +18,7 @@ extra_syntaxes_and_themes = ["syntaxes", "highlight_themes"] [slugify] paths = "on" +paths_keep_dates = true taxonomies = "on" anchors = "on" http://127.0.0.1:1111/posts/2016-10-08-a-post-with-dates ==== --- a/test_site/config.toml +++ b/test_site/config.toml @@ -17,7 +17,8 @@ highlight_theme = "custom_gruvbox" extra_syntaxes_and_themes = ["syntaxes", "highlight_themes"] [slugify] -paths = "on" +paths = "off" +paths_keep_dates = true taxonomies = "on" anchors = "on" http://127.0.0.1:1111/posts/2016-10-08_a-post-with-dates ==== --- a/test_site/config.toml +++ b/test_site/config.toml @@ -17,7 +17,8 @@ highlight_theme = "custom_gruvbox" extra_syntaxes_and_themes = ["syntaxes", "highlight_themes"] [slugify] -paths = "on" +paths = "safe" +paths_keep_dates = true taxonomies = "on" anchors = "on" http://127.0.0.1:1111/posts/2016-10-08_a-post-with-dates
|
Rebased again. I'm happy to change the name if we have a better candidate :) |
Keats
approved these changes
Aug 24, 2022
Yep, we have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual testing:
Existing test_site/config.toml
http://127.0.0.1:1111/posts/a-post-with-dates
====
http://127.0.0.1:1111/posts/2016-10-08-a-post-with-dates
====
http://127.0.0.1:1111/posts/2016-10-08_a-post-with-dates
====
http://127.0.0.1:1111/posts/2016-10-08_a-post-with-dates
Sanity check:
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Are you doing the PR on the
nextbranch?Have you created/updated the relevant documentation page(s)?
Proposal thread:
https://zola.discourse.group/t/proposal-config-option-to-keep-dates-in-slugs/1405