Implemented bottom footnotes with backreferences #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totikom
force-pushed
the
feature/bottom_footnotes
branch
from
7071010
to
d4b12b3
Compare
Keats
requested changes
Apr 23, 2024
totikom
force-pushed
the
feature/bottom_footnotes
branch
from
d86e71e
to
db7f4e8
Compare
totikom
force-pushed
the
feature/bottom_footnotes
branch
from
db7f4e8
to
97b4ea6
Compare
totikom
force-pushed
the
feature/bottom_footnotes
branch
from
97b4ea6
to
26f4aa1
Compare
Keats
reviewed
Apr 26, 2024
components/markdown/src/snapshots/markdown__markdown__tests__def_before_use.snap
Show resolved
Hide resolved
apiraino
reviewed
May 3, 2024
apiraino
reviewed
May 3, 2024
Keats
approved these changes
May 9, 2024
|
Thanks! |
veluca93
pushed a commit
to veluca93/zola
that referenced
this pull request
May 14, 2024
* Implemented bottom footnotes with backreferences Fixes getzola#1285 * Added bottom_footnotes option to configuration.md * Renamed fix_github_style_footnotes() * Added tests for convert_footnotes_to_github_style() * Changed test to plain html instead of Vec<Event> * Added integration test for footnotes * Applied suggested changes
Keats
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Implemented bottom footnotes with backreferences Fixes #1285 * Added bottom_footnotes option to configuration.md * Renamed fix_github_style_footnotes() * Added tests for convert_footnotes_to_github_style() * Changed test to plain html instead of Vec<Event> * Added integration test for footnotes * Applied suggested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option
bottom_footnotes, which renders footnotes with backreferences.It is basically a copy-paste from this example from
pulldown-cmark.Fixes #1285
Sanity check:
Code changes
nextbranch?If the change is a new feature or adding to/changing an existing one: