Fix warning when building site tests #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the site integration tests, we have a file of common code which is used by multiple files in `tests/`. However, not all functions in this file are used by all files in `tests/`. As Cargo compiles each `tests/*.rs` file as a separate crate, this means that some of these crates end up with unused code. Rust notices this and prints a warning. Let's tell Rust that we don't care about dead code in this file so that the warning is not printed.
|
Thanks; that annoyed me greatly! |
Keats
pushed a commit
that referenced
this pull request
Feb 3, 2020
For the site integration tests, we have a file of common code which is used by multiple files in `tests/`. However, not all functions in this file are used by all files in `tests/`. As Cargo compiles each `tests/*.rs` file as a separate crate, this means that some of these crates end up with unused code. Rust notices this and prints a warning. Let's tell Rust that we don't care about dead code in this file so that the warning is not printed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the site integration tests, we have a file of common code which is
used by multiple files in
tests/. However, not all functions inthis file are used by all files in
tests/.As Cargo compiles each
tests/*.rsfile as a separate crate, thismeans that some of these crates end up with unused code. Rust notices
this and prints a warning.
Let's tell Rust that we don't care about dead code in this file so
that the warning is not printed.