Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colon gets inserted in to URLs just before the username #31

Closed
JacobDB opened this issue Jan 10, 2019 · 7 comments
Closed

Colon gets inserted in to URLs just before the username #31

JacobDB opened this issue Jan 10, 2019 · 7 comments
Labels

Comments

@JacobDB
Copy link

JacobDB commented Jan 10, 2019

Not sure what's happening here, but when I run a command like chan release 1.0.0, the URLs that get output are like so:

https://github.com/:JacobDB/pwa-install-prompt/compare/v1.0.0...HEAD

As you can see, there's a : just before my username, and thus when you try to visit the URL, you get a message "Not found."

The package.json for the project I was testing on is available here.

@tinchoz49
Copy link
Contributor

Hi @JacobDB ! how are you? Can you check if the next version fix your issue?

@JacobDB
Copy link
Author

JacobDB commented Jan 18, 2019

@tinchoz49 just had a chance to test it – it does fix the colon problem, except it doesn't seem to generate any URLs unless I manually specify --git-template. Not sure if that's intentional or not.

@tinchoz49
Copy link
Contributor

Hey @JacobDB! thanks for taking the time to check this.

A few questions:

  • Are you running chan inside a git a repo?
  • Are you getting some output log from chan?

@tinchoz49
Copy link
Contributor

By default, if you run chan inside a git repo with a remote url defined, chan is going to try to generate the compare url.

@tinchoz49
Copy link
Contributor

Hi @JacobDB ! we released the new version, can you check if this issue was fixed in your case?

@tinchoz49 tinchoz49 added the bug label Apr 17, 2019
@JacobDB
Copy link
Author

JacobDB commented May 9, 2019

Sorry for the delay, I finally got around to testing this. I keep receiving the following error whenever I run chan release 0.1.0 (with any version numbrer):

[chan] [release] › ✖  error     TypeError: Cannot destructure property `template` of 'undefined' or 'null'.

It happens on both old and new projects; I tried deleting my CHANGELOG.md and running chan init just to be sure, and I keep getting this error. chan --version returns 2.0.0 so I think I'm on the latest release.


After a little further testing, this only seems to be occurring on my projects which have origin set to my self-hosted GitLab server. Seems like some sort of incompatibility with that?

@JacobDB
Copy link
Author

JacobDB commented May 9, 2019

Actually, I'll open a second issue for this new problem. It seems that this issue is indeed fixed.

@JacobDB JacobDB closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants