Added close method to callback list. #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables `await feed.close()` to block until it's actually closed.
|
@dpaez @tinchoz49 Is there something I can do to get these tests passing? I'm not sure if they're being caused by my change. 😅 |
|
Hey @RangerMauve I will take a look today ;) |
|
I fixed the issue and to speed up a little bit I put the close method. Published in v2.1.0 👍 |
|
as always thanks for the help @RangerMauve ! |
|
Thank you @tinchoz49 ! Always great to see this library flourish. 💜 Honestly makes a huge difference when making stuff with hypercore. 😤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
await feed.close()to block until it's actually closed.