Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for vault api integration #77

Closed
dpaez opened this issue Sep 3, 2020 · 0 comments · Fixed by #83
Closed

Tweaks for vault api integration #77

dpaez opened this issue Sep 3, 2020 · 0 comments · Fixed by #83

Comments

@dpaez
Copy link
Contributor

dpaez commented Sep 3, 2020

We can start using the modules endpoint and start adjusting the response parse on our end. We are currently expecting the following params:

   "params": {
    "keys": {
      "type": "array",
      "items": {
        "type": "object",
        "props": {
          "url": {
            "type": "string"
          },
          "title": {
            "type": "string",
            "empty": "false"
          },
          "id": {
            "type": "number"
          },
          "created_at": {
            "type": "string"
          }
        }
      }
    }

We can relax those as just expect an url. Everything else will be optional for now.

@dpaez dpaez changed the title Adjust setting for vault api integration Tweaks for vault api integration Sep 3, 2020
@dpaez dpaez added this to the release-v1.0.0 milestone Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants