Skip to content

Commit

Permalink
Lint.
Browse files Browse the repository at this point in the history
  • Loading branch information
jamadden committed Jul 9, 2023
1 parent 03926ad commit 748ceda
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
19 changes: 11 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -228,14 +228,6 @@ jobs:
python -c 'import gevent.ares; print(gevent.ares)'
ccache -s
- name: Lint
if: matrix.python-version == '3.10' && startsWith(runner.os, 'Linux')
# We only need to do this on one version.
# We do this here rather than a separate job to avoid the compilation overhead.
# TODO: Revisit this when we have caching of that part.
run: |
pip install -U pylint
python -m pylint --rcfile=.pylintrc gevent
- name: "Tests: Basic"
run: |
python -m gevent.tests --second-chance $G_USE_COV
Expand Down Expand Up @@ -314,6 +306,17 @@ jobs:
flag-name: run-${{ join(matrix.*, '-') }}
parallel: true

- name: Lint
if: matrix.python-version == '3.10' && startsWith(runner.os, 'Linux')
# We only need to do this on one version.
# We do this here rather than a separate job to avoid the compilation overhead.
# 20230707: Python 3.11 crashes inside pylint/astroid on _ssl3.py;
# reverting to Python 3.10 solved that.
# TODO: Revisit this when we have caching of that part.
run: |
pip install -U pylint
python -m pylint --rcfile=.pylintrc gevent
coveralls_finish:
needs: test
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions src/gevent/tests/test__ares_host_result.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ def _test(self, protocol):
dumped = pickle.dumps(r, protocol)
loaded = pickle.loads(dumped)
self.assertEqual(r, loaded)
# pylint:disable=no-member
self.assertEqual(r.family, loaded.family)


Expand Down

0 comments on commit 748ceda

Please sign in to comment.