Skip to content

Commit

Permalink
Preparing release 21.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
jamadden committed Jan 15, 2021
1 parent d54515c commit 94e52b1
Show file tree
Hide file tree
Showing 6 changed files with 58 additions and 38 deletions.
55 changes: 55 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,61 @@

.. towncrier release notes start
21.1.0 (2021-01-15)
===================


Bugfixes
--------

- Make gevent ``FileObjects`` more closely match the semantics of native
file objects for the ``name`` attribute:

- Objects opened from a file descriptor integer have that integer as
their ``name.`` (Note that this is the Python 3 semantics; Python 2
native file objects returned from ``os.fdopen()`` have the string
"<fdopen>" as their name , but here gevent always follows Python 3.)
- The ``name`` remains accessible after the file object is closed.

Thanks to Dan Milon.
See :issue:`1745`.


Misc
----

Make ``gevent.event.AsyncResult`` print a warning when it detects improper
cross-thread usage instead of hanging.

``AsyncResult`` has *never* been safe to use from multiple threads.
It, like most gevent objects, is intended to work with greenlets from
a single thread. Using ``AsyncResult`` from multiple threads has
undefined semantics. The safest way to communicate between threads is
using an event loop async watcher.

Those undefined semantics changed in recent gevent versions, making it
more likely that an abused ``AsyncResult`` would misbehave in ways
that could cause the program to hang.

Now, when ``AsyncResult`` detects a situation that would hang, it
prints a warning to stderr. Note that this is best-effort, and hangs
are still possible, especially under PyPy 7.3.3.

At the same time, ``AsyncResult`` is tuned to behave more like it did
in older versions, meaning that the hang is once again much less
likely. If you were getting lucky and using ``AsyncResult``
successfully across threads, this may restore your luck. In addition,
cross-thread wakeups are faster. Note that the gevent hub now uses an
extra file descriptor to implement this.

Similar changes apply to ``gevent.event.Event`` (see :issue:`1735`).

See :issue:`1739`.


----


20.12.1 (2020-12-27)
====================

Expand Down
25 changes: 0 additions & 25 deletions docs/changes/1739.misc

This file was deleted.

10 changes: 0 additions & 10 deletions docs/changes/1745.bugfix

This file was deleted.

2 changes: 1 addition & 1 deletion src/gevent/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#: Use ``pkg_resources.parse_version(__version__)`` or
#: ``packaging.version.Version(__version__)`` to get a machine-usable
#: value.
__version__ = '20.12.2.dev0'
__version__ = '21.1.0'


__all__ = [
Expand Down
2 changes: 1 addition & 1 deletion src/gevent/_interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def run_callback_threadsafe(func, *args):
loop to notice that the *func* has been scheduled (e.g., it causes
the loop to wake up).
.. versionadded:: NEXT
.. versionadded:: 21.1.0
.. seealso:: :meth:`asyncio.loop.call_soon_threadsafe`
The :mod:`asyncio` equivalent.
Expand Down
2 changes: 1 addition & 1 deletion src/gevent/monkey.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def is_anything_patched():
# it is 100% reliable in the event of third-party patch functions that
# don't use ``saved``.
#
# .. versionadded:: NEXT
# .. versionadded:: 21.1.0
return bool(saved)


Expand Down

0 comments on commit 94e52b1

Please sign in to comment.