Skip to content

Commit

Permalink
Stop ignoring FrameType and TracebackType during leakchecks.
Browse files Browse the repository at this point in the history
They're important objects. Locally, the 3.11 tests pass fine this way.

The 2.7 tests had two failures, one from being unable to make a connection in test__server, and one from a timeout in test__doctest. I suspect those are unrelated; lets see what CI says.
  • Loading branch information
jamadden committed Oct 13, 2022
1 parent 93c6542 commit b45460c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/gevent/testing/leakcheck.py
Expand Up @@ -21,7 +21,6 @@

import sys
import gc
import types
from functools import wraps
import unittest

Expand Down Expand Up @@ -52,8 +51,10 @@ class and specify variants of behaviour (such as pool sizes).

class _RefCountChecker(object):

# Some builtin things that we ignore
IGNORED_TYPES = (tuple, dict, types.FrameType, types.TracebackType)
# Some builtin things that we ignore.
# For awhile, we also ignored types.FrameType and types.TracebackType,
# but those are important and often involved in leaks.
IGNORED_TYPES = (tuple, dict,)
try:
CALLBACK_KIND = gevent.core.callback
except AttributeError:
Expand Down

0 comments on commit b45460c

Please sign in to comment.