Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test__subprocess_interrupted.py sometimes fails with AssertionError #196

Closed
denik opened this issue Nov 10, 2012 · 1 comment
Closed

test__subprocess_interrupted.py sometimes fails with AssertionError #196

denik opened this issue Nov 10, 2012 · 1 comment

Comments

@denik
Copy link
Member

denik commented Nov 10, 2012

For example, https://travis-ci.org/SiteSupport/gevent/jobs/3141051/#L4645 :

| GEVENT_FILE=thread GEVENT_RESOLVER=thread /usr/bin/python2.6 -u test__subprocess_interrupted.py
Traceback (most recent call last):
File "test__subprocess_interrupted.py", line 17, in <module>
assert err.strip() == 'bye', repr(err)
AssertionError: 'bye\nUnhandled exception in thread started by \nError in sys.excepthook:\n\nOriginal exception was:\n'
! GEVENT_FILE=thread GEVENT_RESOLVER=thread /usr/bin/python2.6 -u test__subprocess_interrupted.py [code 1] [took 0.6s]

Seems to be timing-related, might be possible to reproduce by looping this test over.

@jamadden
Copy link
Member

This test is currently marked as FLAKY in known_failures.py, but I don't remember the last time I actually saw it fail. I'm not able to reproduce a crash running in a loop locally.

That said, I'm going to leave it marked as FLAKY, but, in the interests of triage for 1.2, I'm going to close this issue.

A good cleanup task would be to go back through all the entries marked FLAKY and re-evaluate them.

hashbrowncipher pushed a commit to hashbrowncipher/gevent that referenced this issue Oct 20, 2018
…n-1465935081972 (pull request gevent#196)

Remove invalid return value in tox.cmdline() example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants