Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gevent 1.1b1 monkey.patch_builtins() crashes PyPy 2.6.0 #618

Closed
parasyte opened this issue Jul 21, 2015 · 3 comments
Closed

gevent 1.1b1 monkey.patch_builtins() crashes PyPy 2.6.0 #618

parasyte opened this issue Jul 21, 2015 · 3 comments

Comments

@parasyte
Copy link
Contributor

Details in the PyPy tracker: https://bitbucket.org/pypy/pypy/issues/2089/crash-in-pypy-260-linux64-with-gevent-11b1

I do not know whether this is the gevent lock implementation misbehaving, or a bug in PyPy (have not investigated further than reducing a test case). I filed it against PyPy, and linking here for reference.

@parasyte
Copy link
Contributor Author

From the PyPy core dump backtrace, I would say it looks a lot like import recursion. This is very likely related: 0924a16#diff-da8f63ebb2bd4dab3782671c16926349

@jamadden
Copy link
Member

Thanks for the report and the reproducible example. It should be fixed now.

I'm not sure I'd call this a bug in either gevent or PyPy (though it would be nice if PyPy didn't crash and reliably raised the RuntimeError on all platforms, but cpyext has its sharp edges). It's more of an incompatibility due to implementation details on certain platforms...and gevent monkeys (hah!) with those implementation details. This is the kind of thing we'll have to watch out for as new versions come out.

@parasyte
Copy link
Contributor Author

@jamadden Looks good here. Much appreciated!

hashbrowncipher pushed a commit to hashbrowncipher/gevent that referenced this issue Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants