-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gevent 1.1a2 TypeError during socket error handling after monkey.patch_socket() on Windows #628
Comments
I believe this is fixed with 39ea1cb. Can you retry with current master? |
Works better. [Note: I've tested only this single changeset applied against 1.1a2, as I can't compile gevent master with mingw, and don't have vc++ handy.] The only thing is that slightly different exception is raised. Without monkey patching: With monkey patching: I don't care about this difference, but maybe somebody does. |
Thank you for your report. Since it looks like the TypeError is gone, and the basic types of the raised errors are all correct and only some trailing arguments differ, I'm going to go ahead and close this. If someone runs into a case where that matters, please feel free to open a specific bug about that. |
FWIW, if it helps, you can now grab pre-built wheel files for most any commit for 32 and 64-bit windows by following the links to a (green) build on https://ci.appveyor.com/project/denik/gevent/history, finding the appropriate bitness, and clicking the Artifacts tab. |
* gevent#544 tox --version shows registered plugins now * add news fragment * make easier to test and add tests
gevent 1.1a2, requests 2.7.0, Python 3.4.3 on Windows
STEPS TO REPRODUCE:
Any kind of win socket error in this place will fail the same way, not only TimeoutError - I've seen also:
TypeError: 'ConnectionRefusedError' object is not subscriptable
TypeError: 'OSError' object is not subscriptable
Without monkey patching it works correctly (ultimately requests.exceptions.ConnectionError raised):
The text was updated successfully, but these errors were encountered: