Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout exception shadows parameter in wait in _socketcommon.py #635

Closed
jayalane opened this issue Aug 11, 2015 · 1 comment
Closed

timeout exception shadows parameter in wait in _socketcommon.py #635

jayalane opened this issue Aug 11, 2015 · 1 comment

Comments

@jayalane
Copy link

And so running my tests gets:

  File "/x/home01/caustinlane/infra-py/infra/lib/linux_x86_py27/gevent/_socketcommon.py", line 143, in wait
    timeout_exc = timeout_exc if timeout_exc is not _NONE else timeout('timed out')
TypeError: 'float' object is not callable

Bad commit is 2fc52c0

I will submit PR. I think just making the exception being Timeout('whatever') would be the intent.

@jayalane
Copy link
Author

Ahh, now even Timeout(timeout, 'timed out') seems wrong. You just need 1 exception. I think

else 'timed out'

reflects the intent of the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant