Make Semaphores fair. #1488
Merged
Make Semaphores fair. #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve order of wakeups. Take steps to avoid going back to the O(n^2) old behaviour, though, much like Greenlet does. This means we auto-unlink links as we call them. Most users won't notice as that's a very low-level method, but baseserver.py was relying on the same rawlink being called every time a semaphore became ready. That was *a lot*, so this eliminates some calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve order of wakeups. Take steps to avoid going back to the O(n^2) old behaviour, though, much like Greenlet does.
This means we auto-unlink links as we call them. Most users won't notice as that's a very low-level method, but baseserver.py was relying on the same rawlink being called every time a semaphore became ready. That was a lot (~once per request) so this eliminates a lot of needless calls.
Fixes #1487