SSL fixes for python 2.7.9 #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ml31415 The code currently merged into the 1.0.2 and master branches went in a different direction than Eugeny@2c5302b. Essentially, The |
|
I'm totally fine with closing this pull request in this case. I just wanted to make sure, no erroneous calls to sslwrap remain in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #477 based on Eugeny@2c5302b and additionally also fixes the socket connect method, which seemd to be left out there. I'd suggest to either take this request or adjust the other patch accordingly, before merging this into the new release.