Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Windows failures and enable AppVeyor #624

Merged
merged 10 commits into from
Jul 28, 2015
Merged

Fix some Windows failures and enable AppVeyor #624

merged 10 commits into from
Jul 28, 2015

Conversation

denik
Copy link
Member

@denik denik commented Jul 26, 2015

Denis Bilenko added 10 commits July 26, 2015 21:07
to fix this exception:

  Traceback (most recent call last):
    File "test__local.py", line 4, in <module>
      from gevent import monkey; monkey.patch_all()
    File "c:\projects\gevent\gevent\monkey.py", line 369, in patch_all
      patch_socket(dns=dns, aggressive=aggressive)
    File "c:\projects\gevent\gevent\monkey.py", line 276, in patch_socket
      patch_module('socket', items=items)
    File "c:\projects\gevent\gevent\monkey.py", line 102, in patch_module
      patch_item(module, attr, getattr(gevent_module, attr))
  AttributeError: 'module' object has no attribute 'socketpair'
 Traceback (most recent call last):
    File "C:\projects\gevent\greentest\greentest.py", line 213, in wrapped
      return method(self, *args, **kwargs)
    File "C:\projects\gevent\greentest\greentest.py", line 202, in wrapped
      return method(self, *args, **kwargs)
    File "C:\projects\gevent\greentest\greentest.py", line 88, in wrapped
      return method(self, *args, **kwargs)
    File "C:\projects\gevent\greentest\test__server.py", line 267, in test_serve_forever
      self.assertConnectionRefused()
    File "C:\projects\gevent\greentest\test__server.py", line 114, in assertConnectionRefused
      conn = self.makefile()
    File "C:\projects\gevent\greentest\test__server.py", line 86, in makefile
      sock.connect((self.server.server_host, self.server.server_port))
    File "c:\projects\gevent\gevent\_socket3.py", line 261, in connect
      raise error(result, strerror(result))
    File "c:\projects\gevent\gevent\win32util.py", line 89, in formatError
      return self.winError(errorcode)[1]
  TypeError: 'OSError' object is not subscriptable
libev\ev.c(1813) : error C2059: syntax error : 'type'
Under Windows that command actually breaks stuff, since 'echo' without arguments prints 'ECHO is off.'.
it does not exist here. Instead, manually copy all build commands into appveyor.yml.

Note, ECHO without arguments prints "ECHO is off." on Windows, so it should not be used.
 C:\Python27\python.exe -u test_hub_join_timeout.py
  Traceback (most recent call last):
    File "test_hub_join_timeout.py", line 44, in <module>
      result = gevent.wait(timeout=10)
    File "C:\Python27\lib\contextlib.py", line 24, in __exit__
      self.gen.next()
    File "test_hub_join_timeout.py", line 22, in expected_time
      assert expected - fuzzy <= elapsed <= expected + fuzzy, 'Expected: %r; elapsed: %r' % (expected, elapsed)
  AssertionError: Expected: 0.1; elapsed: 0.15600013732910156
denik added a commit that referenced this pull request Jul 28, 2015
Fix some Windows failures and enable AppVeyor
@denik denik merged commit 1e3ea27 into master Jul 28, 2015
@denik denik deleted the appveyor-test branch July 28, 2015 19:54
jamadden added a commit that referenced this pull request Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant