Use modern CFFI methods; drop unsupported PyPy versions < 2.6.1 #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets the CFFI backend be used on CPython and is more maintainable going forward. Initial benchmarking of the CFFI backend on CPython shows it to be a few percent slower than the cython backend, but probably not significantly so. Note that the tests are not expected to pass on Travis/pypy yet, because Travis pypy is too old. Use of pyenv may be required.
…. Fix a bug changing the fd and events of a io watcher and test it. Test pypy/windows.
…rs with an earlier setuptools import.
…libev_vfd if we don't need it. Update install.ps1.
…e threaded file ops won't be used, and c-ares isn't a recommended configuration.
|
The Windows/AppVeyor build is experiencing some timing related failures. This does not seem to be related to this branch as even simple non-code changes to master are also failing for the same reasons. |
jamadden
added a commit
that referenced
this pull request
Nov 30, 2015
Use modern CFFI methods; drop unsupported PyPy versions < 2.6.1
hashbrowncipher
pushed a commit
to hashbrowncipher/gevent
that referenced
this pull request
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on the mailing list and twitter, this PR modernizes the CFFI usage and requires CFFI >= 1.3.1, and thus PyPy >= 2.6.1. I didn't get any feedback about anyone requiring older PyPy versions. gevent already needed PyPy >= 2.6.1 to really function correctly with signals and only functioned in a degraded mode on older PyPy versions.
In addition to using supported methods, a side benefit of modern CFFI is much faster import times.
To use a newer version of PyPy on Travis CI, this required switching the build matrix to pyvenv, which cleans up the matrix and gives us explicit control over Python versions. (Code based on hypothesis build.)
In addition, this PR fixes an issue with the
iowatcher discovered during testing (could be ported independently). It also does the groundwork for supporting CFFI on Windows, but I ran into several problems with that (documented in comments).cythoncppissue on Windows/PyPy (and likely a resource warning on Py3)