Feat/doc sign #17
Merged
Feat/doc sign #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jesusantguerrero
commented
Jun 30, 2020
•
jesusantguerrero
commented
- Add support for fixed filters in gw-browse
- Add support for date range
- Add top left pagination slots
- Add actions slot
SparoHawk
requested changes
Jul 16, 2020
| @@ -370,13 +377,19 @@ export default { | |||
| }, | |||
| searchableFields() { | |||
| return this.tableFields.filter(field => field.searchable).map(field => field.name); | |||
| }, | |||
| mainDateField() { | |||
There was a problem hiding this comment.
So what happens where there is more than one date field in the filterable fields?
There was a problem hiding this comment.
It should't be more than one by the moment that's why is called mainDateField; but later, maybe we can allow the User decide which date field to use or address the problem in custom filters.
what do you think?
Co-authored-by: Rogelio Morey <rogelio@mctekk.com>
SparoHawk
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.