Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue by checking when if sample has all 0s #561

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

EricTulowetzke
Copy link
Collaborator

in edgeR if an sample has all 02 then an error is thrown.

nf-core/smrnaseq#134

This code will check if samples have all 0s and tell the user that they should remove it.

Refactor pre_process to start out with the worst return and add values if they get to that point in the workflow. If a sample has all 0s it will return early so the error is not thrown.

@EricTulowetzke
Copy link
Collaborator Author

This should fix the #549 issue.

@gexijin gexijin merged commit 5775050 into master Sep 10, 2023
@gexijin gexijin deleted the 549_better_error_and_do_not_disconnect branch September 10, 2023 18:03
@gexijin
Copy link
Owner

gexijin commented Sep 10, 2023

Thanks Eric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants