For mozilla-mobile#21933 - Refresh history items everytime the fragme…

…nt is opened
gexsi · Mar 7, 2022 · 48c68d9 · 48c68d9
1 parent 7f70670
commit 48c68d9
Showing 1 changed file with 13 additions and 16 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt
@@ -14,7 +14,6 @@ import android.view.MenuItem
 import android.view.View
 import android.view.ViewGroup
 import androidx.appcompat.app.AlertDialog
-import androidx.lifecycle.Observer
 import androidx.lifecycle.lifecycleScope
 import androidx.navigation.NavDirections
 import androidx.navigation.fragment.findNavController
@@ -113,15 +112,6 @@ class HistoryFragment : LibraryPageFragment<History>(), UserInteractionHandler {
 
         historyProvider = DefaultPagedHistoryProvider(requireComponents.core.historyStorage)
 
-        viewModel = HistoryViewModel(historyProvider)
-
-        viewModel.userHasHistory.observe(
-            this,
-            Observer {
-                historyView.updateEmptyState(it)
-            }
-        )
-
         requireComponents.analytics.metrics.track(Event.HistoryOpened)
 
         setHasOptionsMenu(true)
@@ -148,12 +138,19 @@ class HistoryFragment : LibraryPageFragment<History>(), UserInteractionHandler {
             historyView.update(it)
         }
 
-        viewModel.history.observe(
-            viewLifecycleOwner,
-            Observer {
-                historyView.historyAdapter.submitList(it)
-            }
-        )
+        // Data may have been updated in below groups.
+        // When returning to this fragment we need to ensure we display the latest data.
+        viewModel = HistoryViewModel(historyProvider).also { model ->
+            model.userHasHistory.observe(
+                viewLifecycleOwner,
+                historyView::updateEmptyState
+            )
+
+            model.history.observe(
+                viewLifecycleOwner,
+                historyView.historyAdapter::submitList
+            )
+        }
     }
 
     override fun onResume() {