enable ssl connections through IRC-js api #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the callback to `Channel#join` doesn't receive the new channel object as the first argument. this was causing tests to fail. i tweaked the tests to just use the return value of `join` instead of the parameter in the interest of just getting the tests to pass. ideally i would fix the argument, but that was a bit more involved, and i just want to debug the network error problem.
this allows the user to include an `ssl` hash (or bool) in the server
connection params:
```js
var irc = require('irc-js');
var bot = irc.connect({
server: {
address: 'chat.freenode.net',
port: 6697,
ssl: true // could also be: {rejectUnauthorized: false}
},
nick: 'aaronj1335'
}, function(bot) {
// ...
});
```
the value defaults to false, and if it's truthy, it gets passed strait
through to [`tls.connect`][tls-connect].
a couple thoughts:
- i didn't include a unit test only because i don't know what exactly to
test, though i'm happy to implement something
- this messes with the server caching. cases where the user wants two
connections, one ssl and one not ssl to the same server/port will be
handled incorrectly. i think these are rare enough that it's safe to
ignore for now though.
[tls-connect]: http://nodejs.org/api/tls.html
ghost
pushed a commit
that referenced
this pull request
May 12, 2014
enable ssl connections through IRC-js api
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #68
this allows the user to include an
sslhash (or bool) in the serverconnection params:
the value defaults to false, and if it's truthy, it gets passed strait
through to
tls.connect.a couple thoughts:
test, though i'm happy to implement something
connections, one ssl and one not ssl to the same server/port will be
handled incorrectly. i think these are rare enough that it's safe to
ignore for now though.