Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move styled-components as a peerDependency #13

Closed
lcospain opened this issue Jun 11, 2019 · 2 comments
Closed

Move styled-components as a peerDependency #13

lcospain opened this issue Jun 11, 2019 · 2 comments

Comments

@lcospain
Copy link

Describe the bug
Hello, and thank you for this great component. I wanted to use your library as part of a project that depends on styled-components and saw some warnings after installation regarding styled-components being instantiated twice.

To Reproduce
Steps to reproduce the behavior:

  1. Create a folder mkdir repro
  2. Init npm package npm init -y
  3. Install styled-components npm i styled-components
  4. Install react-toggle-component npm i react-toggle-component
  5. After bundling, the console should show the warning available in screenshots

Expected behavior
Styled-components should be put in peerDependencies

Screenshots
Warning message printed to the console :
Warning message

Desktop (please complete the following information):

  • OS: Mac Os
  • Browser: Google Chrome
  • Version: 74

Additional context
Add any other context about the problem here.

@gfazioli
Copy link
Owner

@lcospain Hi, interesting, I'll check soon, thx 👍

@gfazioli
Copy link
Owner

should be ok on v3.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants