Show CPU frequency with logo color. Also remove pysensor dependency #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
git is hard sometimes... |
gfduszynski
reviewed
May 28, 2020
| @@ -45,18 +20,21 @@ def print_available_sources(ctx,value): | |||
| @click.option("--bg-color", "bgColor", default="#00FFFF", help="Background LED's color") | |||
| @click.option("--cpu-color", "cpuColor", default="#FFA500", help="Color of the cpu load LED's") | |||
| @click.option("--brightness", type=click.IntRange(1, 5, clamp=True), default=3) | |||
| @click.option("--interval", type=click.FloatRange(0.01, 60, clamp=True), default=0.2) | |||
| @click.option("--interval", type=click.FloatRange(0.01, 60, clamp=True), default=0.1) | |||
There was a problem hiding this comment.
Is this default value change intentional ?
Edit: Great work, --verbose is a nice touch 👍
There was a problem hiding this comment.
No, default values was only my personal choice and found its way into my PR as I didn't change it back.
There was a problem hiding this comment.
Ok, I'll merge it, but I'll probably change the default back as I found that at 0.1s ring can flicker noticeably in my opinion.
Thanks for this awesome feature 👍
Closed
mpsdskd
added a commit
to mpsdskd/cm-rgb
that referenced
this pull request
May 29, 2020
Merge pull request gfduszynski#35 from mpsdskd/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.