Skip to content

Commit

Permalink
Michael's feedback #1
Browse files Browse the repository at this point in the history
  • Loading branch information
gfichtenholt committed Aug 9, 2021
1 parent 7194f18 commit 38dd719
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/chart.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,13 @@ func (s *Server) getChartTarball(ctx context.Context, repoName string, chartName

// did not find the chart, need to create
// see https://fluxcd.io/docs/components/source/helmcharts/
// TODO (gfichtenholt)
// notes:
// 1. HelmChart object needs to be co-located in the same namespace as the HelmRepository it is referencing.
// 2. flux impersonates a "super" user when doing this (see fluxv2 plug-in specific notes at the end of
// design doc). We should probably be doing simething similar to avoid RBAC-related problems
// 2. As of the time of this writing, flux impersonates a "super" user when doing this
// (see fluxv2 plug-in specific notes at the end of design doc). However, they are backing away from
// this model toward this proposal
// https://github.com/fluxcd/flux2/blob/1c5a25313561771d585c4192d7f330b45753cd99/docs/proposals/secure-impersonation.md
// So we may not necessarily want to follow what flux does today
unstructuredChart := newFluxHelmChart(chartName, repoName, chartVersion)

resourceIfc, err := s.getChartsResourceInterface(ctx, namespace)
Expand Down

0 comments on commit 38dd719

Please sign in to comment.