Michael feedback #1

gfichtenholt · Sep 22, 2021 · 682df8c · 682df8c
1 parent 4c0d677
commit 682df8c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/integration_utils_test.go b/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/integration_utils_test.go
@@ -332,6 +332,8 @@ func randSeq(n int) string {
 }
 
 // global vars
-var letters = []rune("abcdefghijklmnopqrstuvwxyz0123456789")
-var typedClient kubernetes.Interface
-var dynamicClient dynamic.Interface
+var (
+	dynamicClient dynamic.Interface
+	typedClient   kubernetes.Interface
+	letters       = []rune("abcdefghijklmnopqrstuvwxyz0123456789")
+)
diff --git a/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/release_test.go b/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/release_test.go
@@ -656,7 +656,7 @@ func TestUpdateInstalledPackage(t *testing.T) {
 			expectedRelease: flux_helm_release_updated_1,
 		},
 		{
-			name: "returns invalid if installed package doesn't exist",
+			name: "returns not found if installed package doesn't exist",
 			request: &corev1.UpdateInstalledPackageRequest{
 				InstalledPackageRef: &corev1.InstalledPackageReference{
 					Context: &corev1.Context{