Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "gflags" import target which copies properties from ${gflags_LIBRARIES} target #110

Closed
schuhschuh opened this issue Mar 25, 2015 · 0 comments
Closed

Add "gflags" import target which copies properties from ${gflags_LIBRARIES} target #110

schuhschuh opened this issue Mar 25, 2015 · 0 comments
Assignees
@schuhschuh
Labels
3 - done cmake enhancement
Milestone
v2.2.0

Comments

@schuhschuh
Copy link
Member

The use of gflags_LIBRARIES is merely a workaround. It would be nicer to have a "gflags" import target for the (requested) default variant of the gflags library (i.e., static vs. shared and threaded vs. serial).
@schuhschuh schuhschuh self-assigned this Mar 25, 2015
@schuhschuh schuhschuh added this to the v2.2.0 milestone Mar 25, 2015
schuhschuh added a commit that referenced this issue Mar 25, 2015
@schuhschuh
#110 Add "gflags" import target and gflags_TARGET
4a3e681 
The gflags_TARGET contains the name of the originally exported import target whose properties are copied over to the "gflags" import target.
schuhschuh added a commit that referenced this issue Mar 25, 2015
@schuhschuh
#110 Add "gflags" import target and gflags_TARGET
ed1d91f 
The gflags_TARGET variable contains the name of the originally exported import target. The "gflags" import target contains a copy of the relevant properties of this import target created by CMake. The gflags_LIBRARIES variable can be used to be consistent with other packages, but is otherwise no longer needed. In most cases, "target_link_libraries(foo gflags)" should be used.
schuhschuh added a commit that referenced this issue Mar 25, 2015
@schuhschuh
#110 Update CMake example on how to link against gflags library
73178f0
@schuhschuh schuhschuh mentioned this issue Mar 25, 2015
Closed
schuhschuh added a commit that referenced this issue Mar 25, 2015
@schuhschuh
#110 Set gflags_LIBRARIES to value of gflags_TARGET instead of "gflags"
f4f524d
alexsmac added a commit to ceres-solver/ceres-solver that referenced this issue Aug 9, 2015
@alexsmac
Fix bug in gflags' <= 2.1.2 exported CMake configuration.
16ecd40 
- gflags <= 2.1.2 has a bug in its exported gflags-config.cmake:
  gflags/gflags#110 whereby it sets
  gflags_LIBRARIES to a non-existent 'gflags' target.
- This causes linker errors if gflags is installed in a non-standard
  location (as otherwise CMake resolves gflags to -lgflags which
  links if gflags is installed somewhere on the current path).
- We now check for this case, and search for the correct gflags imported
  target and update gflags_LIBRARIES to reference it if found, otherwise
  proceed on to the original manual search to try to find gflags.

Change-Id: Iceccc3ee53c7c2010e41cc45255f966e7b13d526
@edgarriba edgarriba mentioned this issue Feb 29, 2016
Closed
@hlzz hlzz mentioned this issue Jul 15, 2016
Closed
@xialang2012 xialang2012 mentioned this issue Sep 21, 2016
Closed
This was referenced Nov 27, 2016
Closed
Closed
@ZhiyuLiu1993 ZhiyuLiu1993 mentioned this issue Jun 12, 2018
Closed
@ZhiyuLiu1993 ZhiyuLiu1993 mentioned this issue Jul 2, 2018
Closed
@kausalinverse kausalinverse mentioned this issue Oct 24, 2018
Closed
@bennywijaya55 bennywijaya55 mentioned this issue May 29, 2020
Closed
@FashengChen0622 FashengChen0622 mentioned this issue Sep 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schuhschuh schuhschuh

Labels
3 - done cmake enhancement
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
1 participant
@schuhschuh