Enable more warnings for 0.1.0 branch #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`exception InvalidYOJSON` is not used since b9cb92a
type `file_path` is not used since 907764b
type `indirect` is not used at their birth (e020b77)
types `predefined_encoding`, `encoding`, `differences`, `matrix` were used in module `Type1Scheme_`, `Type3`, ..., but they are commented out at 873254e
type `chunk_info` is not used at their birth (c866933)
leque
force-pushed
the
enable-more-warnings
branch
from
ef6803e
to
4e3fa8f
Compare
|
Thank you so much! I confirmed that reverting some changes manually emits errors like the following: File "src/frontend/evaluator.cppo.ml", line 412, characters 8-14:
Error (warning 27 [unused-var-strict]): unused variable ast1.File "src/frontend/evaluator.cppo.ml", line 999, characters 10-28:
Error (warning 39 [unused-rec-flag]): unused rec flag.File "src/frontend/main.ml", line 234, characters 2-38:
Error (warning 37 [unused-constructor]): constructor DisplayLineOption is never used to build values.
(However, this constructor appears in patterns.) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables more warnings of OCaml compiler while building SATySFi itself.
This PR also includes fixes for warnings. This does not aim to improve global code structure, but rewrite code locally to eliminate warnings; simply remove unused code and flags, prefix
_to unused variables, add missing patterns, ..., etc.Removing unused value declarations (fixing warning 32) is a future work since it is unclear to me which declarations should be removed.