Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swinging door handles the end of the data stream correctly #72

Merged
merged 5 commits into from
Dec 22, 2021

Conversation

gfoidl
Copy link
Owner

@gfoidl gfoidl commented Dec 14, 2021

Fixes #70

At the end of the data stream to determine if the penultimate point should be stored or not, a door from the last archived to the final point (= incoming at that time) is constructed, and check whether the penultimate point lies inside the door or not.

In the before / after charts note the point (8, 3).

Before

before

After

after

@gfoidl gfoidl added this to the 2.2.0 milestone Dec 14, 2021
@gfoidl gfoidl merged commit e47ae3d into master Dec 22, 2021
@gfoidl gfoidl deleted the fix-swinging-door branch December 22, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Algorithm does not return correct compressed data sample
1 participant