Add XSelectScheme command #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +65,7 @@ function! s:scheme() | |||
| return '-scheme '. s:scheme_name() | |||
| endfunction | |||
|
|
|||
| function!s:scheme_name() | |||
| function! s:scheme_name() | |||
yep, that seems best.
Maybe we should add a small note that if you mistype the scheme, |
| @@ -72,6 +73,11 @@ function!s:scheme_name() | |||
| return s:chosen_scheme | |||
| endfunction | |||
|
|
|||
| function! s:set_scheme(scheme) | |||
There was a problem hiding this comment.
Should we move this up with build and test? I feel like it makes sense to group actions together, but maybe I'm insane?
There was a problem hiding this comment.
Nope that sounds good
|
PS I'm shocked and delighted with how simple this ended up being.
|
|
Fixes #2 I'll open another issue to cover autocompletion. |
This command allows users to switch the scheme being built. When doing so we also reset the current SDK in case the scheme targets a different OS.
|
Updated for feedback! |
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command allows users to switch the scheme being built. When doing
so we also reset the current SDK in case the scheme targets a different
OS.
I pushed the xcpretty docs down since it made sense to group commands together. If you'd prefer this not change let me know and I can swap them.
I also didn't write much for the help since there's not a lot to this command, let me know if there's anything else I should include.