Skip to content

Commit

Permalink
Don't install the package in edit mode to fix OptionConflictError
Browse files Browse the repository at this point in the history
The entrypoints package (https://github.com/takluyver/entrypoints/) was introduced in flake8 3.7.

Unfortunately it will detect entrypoints multiple times when the plugin is installed in editable mode
because of this line: https://github.com/takluyver/entrypoints/blob/master/entrypoints.py#L192

The '-' is not in the directory name when you install a package in edit mode so when the python
path contains duplicate paths to the same module flake8 will instantiate the plugin multiple times
as well.
  • Loading branch information
Martijn Jacobs committed Mar 18, 2019
1 parent 7a9d6bd commit 5a847aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ python:
- 'pypy3'
cache: pip
install:
- pip install -e .[test]
- pip install .[test]
script:
- flake8 *.py
- pytest run_tests.py
Expand Down

0 comments on commit 5a847aa

Please sign in to comment.