New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support stdin #1
Conversation
02eb6a7
to
a91ab1c
Compare
a91ab1c
to
2484857
Compare
2484857
to
f28d217
Compare
First of all thanks for the pull request! Would you mind to change the context manager for |
def __init__(self, tree, filename): | ||
self.filename = filename | ||
def __init__(self, tree, filename, builtins=None): | ||
self.content = Read.tree(tree) or Read.file(filename) or Read.stdin() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather prefer to have something like:
self.content = Read(tree, filename)
and returns the expected value, i.e. hiding the complexity inside Read
instead of having it on Flake8Isort
.
@beck ping :-) |
@beck friendly ping :-) |
Fixed on #7 by @mjacksonw and released by yours truly as 1.2. Enjoy! |
👍 |
flake8-isort blew up my IDE because it did not support stdin.
To duplicate:
These changes ensure flake8 will not blowup.
But I noticed that flake8 checkers fail when contents are piped in:
This is an issue upstream and am unsure the best way to fix. I opened:
PyCQA/pycodestyle#443
Also added: