Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 4.x compat + github actions #106

Merged
merged 3 commits into from
Oct 14, 2021
Merged

flake8 4.x compat + github actions #106

merged 3 commits into from
Oct 14, 2021

Conversation

g-as
Copy link
Contributor

@g-as g-as commented Oct 11, 2021

I chose to keep flake8 3.x, but it complexifies the test matrix.

@gforcada
Copy link
Owner

@g-as thanks for the PR! unfortunately, as you can see, travis no longer works for this project 😕 would you be interested in moving the travis CI configuration over to github actions? 🤔 ✨

@g-as
Copy link
Contributor Author

g-as commented Oct 11, 2021

I'll give it a shot.

Are you ok with dropping 2.7 & 3.5?

@g-as g-as changed the title flake8 4.x compat flake8 4.x compat + github actios Oct 12, 2021
@g-as g-as changed the title flake8 4.x compat + github actios flake8 4.x compat + github actions Oct 12, 2021
@gforcada
Copy link
Owner

@g-as yes, although I still (shamefully) have some 2.7 code around, but it's time to let the kid fly 😄

@gforcada gforcada merged commit d6ba8cd into gforcada:master Oct 14, 2021
@gforcada
Copy link
Owner

@g-as thanks for all the work! I will create a new release in a few minutes

@g-as g-as deleted the feature/flake8_4.0 branch October 14, 2021 08:22
@g-as
Copy link
Contributor Author

g-as commented Oct 14, 2021

👍 I'll be around for some adjustments if needed

@gforcada
Copy link
Owner

And you get not only one but two releases 🎉 4.1.0 and 4.1.1 the second one is to fix the wheel, that it was not py3 only, but py2/3.

@gforcada
Copy link
Owner

Let me know if you find problems with them!

@g-as
Copy link
Contributor Author

g-as commented Oct 14, 2021

LOL. Cheers

@g-as
Copy link
Contributor Author

g-as commented Oct 14, 2021

I made two other small PRs, one to update the README badge (pointing to github actions rather than travis), and one the fix the coveralls coverage upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants