Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #21: AttributeError with isort skipped files #22

Merged
merged 1 commit into from
Nov 25, 2016
Merged

Fix #21: AttributeError with isort skipped files #22

merged 1 commit into from
Nov 25, 2016

Conversation

cas--
Copy link
Contributor

@cas-- cas-- commented Nov 25, 2016

  • When a skipped file is passed to isort there will be no
    SortedImport.out_lines attribute but we can check for the
    skipped attribute and stop iteration early.

@cas--
Fix gforcada#21: AttributeError with isort skipped files
106a725 
 - When a skipped file is passed to isort there will be no
   SortedImport.out_lines attribute but we can check for the
   `skipped` attribute and stop iteration early.
@coveralls
Copy link

coveralls commented Nov 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 91.667% when pulling 106a725 on cas--:Issue/21/SkippedFileError into e234c02 on gforcada:master.

@gforcada gforcada merged commit 1e8fb05 into gforcada:master Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cas-- @coveralls @gforcada