ContextExample touch ups #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcjordan
commented
Nov 27, 2016
|
|
||
| const AdvancedTable = AddFilter(DataCtxt(Table)); | ||
| const FilterablePagingTable = AddFilter(DataCtxt(Table)); |
There was a problem hiding this comment.
Renamed everything which was Advanced to be more descriptive
| * @param {string} propName The prop that is to be validated | ||
| * @param {string} componentName The name of the component that the prop belongs to | ||
| */ | ||
| function PropTypeCtxtData(props, propName, componentName) { |
There was a problem hiding this comment.
Since propTypes aren't a FDT specific thing and they clutter these examples, I've moved them to a helper file
| @@ -1,42 +0,0 @@ | |||
| import React from 'react'; | |||
| @@ -9,6 +9,13 @@ var Constants = require('../Constants'); | |||
|
|
|||
| var ExampleHeader = React.createClass({ | |||
| render() { | |||
| const contextDisclamer = this.props.page.fileName === 'ContextExample.js' ? ( | |||
There was a problem hiding this comment.
This is less than ideal, but I didn't see a good way to add this without a larger refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've made some cleanups to your Context example. Please let me know your thoughts.
Motivation and Context
Working on making the context example easier to follow.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: