Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize not only ExpressionStatements but also Expressions as translatable define-calls #125

Closed

Conversation

emilefokkema
Copy link

This PR does two things:

  1. Recognize not only
if(typeof define === 'function'){
   define(/*something*/);
}

as a translatable AMD check, but also

typeof define === 'function' ? define(/*something*/) : 0;

By doing this, it solves #119. This brings with it:

  1. Recognize not only
define(/*something*/);

i.e. a statement (notice the semicolon), as a translatable define-call, but also

define(/*something*/)

i.e. an expression (notice the absence of the semicolon). By doing this, it solves #124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant