Fix pluralization of 'Standort' / 'Standorten' #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this fix is even worth it, since the wording in general dosn't make to much sense for only 1 sensor. |
dbrgn
requested changes
Jun 10, 2018
src/Views.elm
Outdated
| {-| View: Map | ||
| -} | ||
| mapView : Model -> Html Msg | ||
| mapView model = | ||
| page | ||
| ("Finde die aktuelle und historische Wassertemperatur an " | ||
| ++ (model.sensors |> List.length |> toString) | ||
| ++ " Standorten rund um den Zürichsee!" | ||
| ++ (pluralize " Standort" " Standorten" (model.sensors |> List.length)) ++ " rund um den Zürichsee!" |
There was a problem hiding this comment.
Can you break the line at ++? You should probably install elm-vim for auto-formatting.
There was a problem hiding this comment.
(Alternatively you can manually reformat with elm-format on the command line.)
There was a problem hiding this comment.
Ah I made this fix before I did the elm tutorial, because since then I have the plugin installed. Will fix.
Best fix would be to have more sensors 🙂 Maybe you could ask at Sensirion? |
rnestler
force-pushed
the
pluralization-fix
branch
from
aaee71f
to
b090922
Compare
|
@dhasenfratz Because you mentioned it today 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it showed "1 Standorten".