Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consumer_cancel_notify to client_capabilities in Connection::open() #113

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Add consumer_cancel_notify to client_capabilities in Connection::open() #113

merged 2 commits into from
Oct 31, 2023

Conversation

OverworkedCriminal
Copy link
Contributor

@OverworkedCriminal OverworkedCriminal commented Oct 30, 2023 •
edited by gftea
Loading

Close #112

@OverworkedCriminal OverworkedCriminal mentioned this pull request Oct 30, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #113 (89ea076) into main (ce10318) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   85.36%   85.44%   +0.07%     
==========================================
  Files          40       40              
  Lines        6341     6381      +40     
==========================================
+ Hits         5413     5452      +39     
- Misses        928      929       +1
Files Coverage Δ
amqprs/src/api/connection.rs 87.37% <100.00%> (+0.13%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gftea
Copy link
Owner

gftea commented Oct 31, 2023

@OverworkedCriminal LGTM, thanks!!

@gftea gftea merged commit 58d8425 into gftea:main Oct 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gftea gftea gftea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChannelCallback::cancel() not called when server delete queue
2 participants
@OverworkedCriminal @gftea