Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce syscall by combing publish sequence into one write #33

Merged
merged 1 commit into from Jan 23, 2023
Merged

Conversation

gftea
Copy link
Owner

@gftea gftea commented Jan 23, 2023

according to the AMQP protocol, publish content is done in 3 frames: Publish + Header + Body. Current implementation make one write per frame. This is to make one write for all 3 frames of a publish so that reducing syscalls.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #33 (675e268) into main (9ea15f7) will decrease coverage by 0.01%.
The diff coverage is 84.37%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   84.11%   84.11%   -0.01%     
==========================================
  Files          42       42              
  Lines        5629     5639      +10     
==========================================
+ Hits         4735     4743       +8     
- Misses        894      896       +2     
Impacted Files Coverage Δ
amqprs/src/net/reader_handler.rs 67.76% <ø> (ø)
amqprs/src/frame/mod.rs 84.78% <71.42%> (ø)
amqprs/src/net/split_connection.rs 92.96% <85.71%> (-0.35%) ⬇️
amqprs/src/api/channel/basic.rs 86.57% <100.00%> (-0.16%) ⬇️
amqprs/src/frame/content_header.rs 80.52% <100.00%> (ø)
amqprs/src/api/error.rs 33.33% <0.00%> (-11.12%) ⬇️
amqprs/src/api/channel/dispatcher.rs 88.88% <0.00%> (+1.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gftea gftea merged commit aaa9653 into main Jan 23, 2023
@gftea gftea deleted the pub_combo branch February 9, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant