Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for !self.is_len_known and self.is_len_known #71

Merged

Conversation

jdelgadoalfonso
Copy link
Contributor

WIP: close first task of the issue #70

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #71 (81783af) into main (dffc530) will increase coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   85.54%   85.90%   +0.35%     
==========================================
  Files          42       42              
  Lines        5950     6036      +86     
==========================================
+ Hits         5090     5185      +95     
+ Misses        860      851       -9     
Impacted Files Coverage Δ
amqp_serde/src/ser.rs 91.86% <100.00%> (+4.65%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@gftea gftea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gftea gftea merged commit 53238ff into gftea:main Mar 23, 2023
13 checks passed
@gftea gftea mentioned this pull request Mar 24, 2023
3 tasks
@jdelgadoalfonso jdelgadoalfonso deleted the improvement-amqp_serde-design-and-APIs branch March 26, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants