Skip to content

Commit

Permalink
Merge #1977
Browse files Browse the repository at this point in the history
1977: dx12: Increase descriptor heap limits temporarily r=kvark a=grovesNL

See #1945 (comment)

PR checklist:
- [X] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [X] tested examples with the following backends: dx12

As a side note I noticed `make reftests` is failing on dx12 for me (on master).

Co-authored-by: grovesNL <josh@joshgroves.com>
  • Loading branch information
bors[bot] and grovesNL committed Apr 27, 2018
2 parents 0fe18fa + c0fcdae commit 54fe14f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/backend/dx12/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ impl Device {
present_queue: ComPtr<d3d12::ID3D12CommandQueue>,
) -> Self {
// Allocate descriptor heaps
let max_rtvs = 512; // TODO
let max_rtvs = 2048; // TODO
let rtv_pool = native::DescriptorCpuPool {
heap: Self::create_descriptor_heap_impl(
&mut device,
Expand All @@ -507,7 +507,7 @@ impl Device {
max_size: max_rtvs as _,
};

let max_dsvs = 64; // TODO
let max_dsvs = 128; // TODO
let dsv_pool = native::DescriptorCpuPool {
heap: Self::create_descriptor_heap_impl(
&mut device,
Expand Down

0 comments on commit 54fe14f

Please sign in to comment.